Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: invoke progress events during dialing #2596

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

achingbrain
Copy link
Member

If the user passes an onProgress callback to a dial request, invoke the callback with progress events during the dial.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

If the user passes an `onProgress` callback to a dial request,
invoke the callback with progress events during the dial.
@achingbrain achingbrain marked this pull request as ready for review July 2, 2024 12:26
@achingbrain achingbrain requested a review from a team as a code owner July 2, 2024 12:26
@achingbrain achingbrain merged commit 6573cb8 into main Jul 2, 2024
24 checks passed
@achingbrain achingbrain deleted the feat/invoke-progress-events-during-dialing branch July 2, 2024 12:27
@achingbrain achingbrain mentioned this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant